perf: add fast path to OrdinaryGet#5413
Open
Serdnad wants to merge 1 commit into
Open
Conversation
Avoid constructing a PropertyDescriptor for the common case of reading a plain data property. `ordinary_get` now resolves named own-property lookups on ordinary objects in a single shape probe via `PropertyMap::get_own_data_named`, reading the value directly from storage and going straight to the prototype walk on a miss (no redundant second lookup). Gated on the object using the ordinary `__get_own_property__`, so accessors, indexed keys and exotic objects fall back to the spec path. Benchmarks vs baseline: regexp -5.9%, earley-boyer -3.7%, raytrace -3.2%; properties/access -10%, prototypes/chain -10%, strings -12..-23%.
github-actions
Bot
added
the
Waiting On Review
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5413 +/- ##
===========================================
+ Coverage 47.24% 60.27% +13.02%
===========================================
Files 476 567 +91
Lines 46892 63175 +16283
===========================================
+ Hits 22154 38078 +15924
- Misses 24738 25097 +359 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fast path to
OrdinaryGetthat reads a plain data property's value directly from object storage, skippingPropertyDescriptorconstruction.Benchmarks on local machine: