feat(zclassic): Add Zclassic (ZCL) support#4152
feat(zclassic): Add Zclassic (ZCL) support#4152lelonex wants to merge 6 commits intobitpay:masterfrom
Conversation
Add full ZCL support including: - zclassic-bitcore-lib: core library (Equihash, ZIP-205, transparent addresses) - zclassic-bitcore-p2p: P2P networking layer - bitcore-node: ZCL chain module, P2P worker, chain-state provider - crypto-wallet-core: ZCL derivation, transaction builder, address validation - insight: ZCL UI support, logo, constants - Fix negative fee calculation for Sapling/shielded transactions
…ore-lib, regenerate lock file Resolves CI failure: npm ci could not find zclassic-bitcore-lib in registry. Changed dependency from npm semver to file:../zclassic-bitcore-lib (local monorepo package).
…as local dependencies Required by src/providers/libs/index.ts at runtime. Both resolved as file: references to local monorepo packages.
…back In environments where zclassic packages are not installed (e.g. CI running npm ci on individual packages), the eager require was crashing at module load time. Now ZCL libs are loaded lazily and silently skipped if not available.
|
Note: the test:crypto-rpc CI failure seems a pre-existing flaky test unrelated to this PR. The error is ProviderError: transaction indexing is in progress on the geth node — a race condition in the test environment during startup. ZCL (Zclassic) is a Bitcoin-protocol chain and uses its own node (zclassicd) via the existing bitcore-node P2P infrastructure, completely independent from EVM/geth. The ZCL integration adds zclassic-bitcore-lib and zclassic-bitcore-p2p as local monorepo packages, with no impact on the Ethereum stack. |
Prevents flaky CI failure where hardhat:deploy runs before geth has finished transaction indexing. Polls eth_blockNumber with retries (60x2s) before proceeding. Also adds .eslintignore for blockchain/ dir.
Replaces custom polling script with battle-tested wait-on package. Waits up to 2 minutes for geth:8545 to be ready before deploying contracts, fixing flaky CI failure (ProviderError: transaction indexing is in progress).
|
Hey @lelonex , thanks for the PR! Before I can even consider this work, please review the CONTRIBUTING.md doc, specifically the part about commit signing. I can't merge this PR until all your commits are signed & verified. Also, in keeping with the pattern of this repo, please rename |
2 participants
Summary
This PR adds full support for Zclassic (ZCL) — a community-driven, open-source fork of Zcash — to the Bitcore monorepo.
Zclassic was created in 2016 by removing the 20% founder's reward from Zcash, making it a purely community-owned coin. It uses the Equihash proof-of-work algorithm, supports transparent (
t1/t3) and shielded addresses, and is fully compatible with the Zcash transaction format (ZIP-205/Sapling).Changes
New Packages
packages/zclassic-bitcore-lib— Core JavaScript library for Zclassic. Handles key derivation, address encoding/decoding, transaction building and signing, Equihash block header parsing, and ZIP-205 Sapling signature hash computation.packages/zclassic-bitcore-p2p— P2P networking layer for Zclassic. Implements the Zclassic wire protocol (magic bytes0x24e92764, port8033, protocol version170011).Modified Packages
packages/bitcore-nodemodules/zclassic/— ZCL chain module, P2P sync worker, and verification peerproviders/chain-state/zcl/— chain state provider for ZCLproviders/libs/index.ts— registerzclassic-bitcore-libandzclassic-bitcore-p2pmodules/index.ts— register ZCL modulemodels/block.ts— skip transactions with negative fees in fee statistics (affects Sapling shielded transactions)models/transaction.ts— clamp negative fee values to 0 (SaplingvalueBalancecaused incorrect negative fees)packages/crypto-wallet-coresrc/constants/chains.ts— ZCL chain identifiersrc/derivation/zcl/— BIP44 derivation path m/44'/147'/0'/0/0src/transactions/zcl/— transaction buildersrc/validation/zcl/— address validationsrc/message/zcl.ts— message signingsrc/types/zcl-modules.d.ts— TypeScript ambient declarationspackages/insightconstants.ts— ZCL API routinghelper-methods.ts—getApiRoot()returns correct endpoint for ZCLzclassic-bitcore-libTechnical Details
0x24e927640x1C 0xB8— t1 addresses0x1C 0xBD— t3 addressesTesting
The implementation has been tested against a live Zclassic mainnet node (
zclassicd v2.1.1-10):170011valueBalanceedge casesReferences