Add tests to bitcore-cli by kajoseph · Pull Request #4105 · bitpay/bitcore

kajoseph · 2026-02-12T17:07:05Z

Description

Need more tests in bitcore-cli

Changelog

Adds tests to bitcore-cli
Fixes a few bugs
- BWC/S: Sending max amount should work for UTXO chains
- CLI: Gate SOL from multi-party wallets
- Various other bitcore-cli bugs
Removes tsx dependency from BWC

Testing Notes

cd packages/bitcore-cli && npm run test

Checklist

I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.
I have added the appropriate package tag(s) (e.g. BWC if modifying the bitcore-wallet-client package, CLI if modifying the bitcore-cli package, etc.)
I have verified that this is not an existing PR (open or closed)

…ion tests

Co-authored-by: Copilot <copilot@github.com>

Copilot

Pull request overview

Adds a substantial automated test suite for bitcore-cli (unit tests + end-to-end CLI flows against a local BWS + MongoDB), and adjusts CLI behavior/types to support those tests (wallet creation/join flows, tx proposal pagination/actions, and build/test tooling).

Changes:

Added extensive bitcore-cli test coverage (utils/prompts/filestorage + CLI interaction tests for create/join, proposals, addresses).
Updated CLI wallet + txproposals logic to support new scenarios (join secret plumbing, pagination refactor, chain-specific behavior, token lookup scoping).
Updated build/test tooling (prod tsconfig, test scripts, test wallet fixtures, and new dev deps for running an embedded BWS + MongoDB).

Reviewed changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/bitcore-wallet-client/src/index.ts	Re-exports `Constants` from BWC for downstream usage.
packages/bitcore-cli/types/wallet.d.ts	Updates wallet `create()` type signature for join-secret flow + new return fields.
packages/bitcore-cli/tsconfig.prod.json	Adds prod TS config excluding tests.
packages/bitcore-cli/test/wallets/btc-singlesig.json	Adds wallet fixture used by CLI tests.
packages/bitcore-cli/test/wallets/btc-multisig-copayer1.json	Adds multisig copayer fixture.
packages/bitcore-cli/test/wallets/btc-multisig-copayer2.json	Adds multisig copayer fixture.
packages/bitcore-cli/test/utils.test.ts	Adds unit tests for `Utils`.
packages/bitcore-cli/test/tssCoordinator.ts	Adds helper to coordinate multiple CLI processes for TSS tests.
packages/bitcore-cli/test/proposals.test.ts	Adds end-to-end tests for viewing/accepting/rejecting/deleting proposals.
packages/bitcore-cli/test/prompts.test.ts	Adds tests for prompt helpers (env defaults, validation, cancel flow).
packages/bitcore-cli/test/helpers.ts	Adds BWS/Mongo-backed test harness and blockchainExplorer mock utilities.
packages/bitcore-cli/test/filestorage.test.ts	Adds tests for `FileStorage` behavior.
packages/bitcore-cli/test/data/walletsData.ts	Adds BWS wallet seed data for tests.
packages/bitcore-cli/test/data/test-config.ts	Adds test config for Mongo/BWS ports.
packages/bitcore-cli/test/data/proposalsData.ts	Adds BWS proposal seed data.
packages/bitcore-cli/test/data/addressesData.ts	Adds BWS address seed data.
packages/bitcore-cli/test/create.test.ts	Adds end-to-end tests for single-sig, multisig, and TSS wallet creation/join flows.
packages/bitcore-cli/test/commands.test.ts	Fixes type import paths for command tests.
packages/bitcore-cli/test/address.test.ts	Adds end-to-end tests for address generation + pagination.
packages/bitcore-cli/src/wallet.ts	Adds join-secret support to `create()`, adjusts completion/save logic, adds regtest currency URL requirement.
packages/bitcore-cli/src/utils.ts	Adjusts goodbye messages, `parseAmount()` error behavior, and documents `paginate()` types.
packages/bitcore-cli/src/commands/txproposals.ts	Refactors proposal viewing/actions onto shared paginator, adds `--page` option.
packages/bitcore-cli/src/commands/token.ts	Restricts token lookup to the wallet’s chain.
packages/bitcore-cli/src/commands/join/joinMultiSig.ts	Routes multisig join through `wallet.create({ joinSecret })`.
packages/bitcore-cli/src/commands/join/index.ts	Blocks Solana for multi-party join flows.
packages/bitcore-cli/src/commands/create/index.ts	Disables multi-party prompt for Solana creation.
packages/bitcore-cli/src/commands/create/createThresholdSig.ts	Adds explicit Solana guard for TSS creation.
packages/bitcore-cli/src/commands/create/createMultiSig.ts	Adds explicit chain support guard for multisig creation.
packages/bitcore-cli/package.json	Updates test/coverage scripts (copy fixtures, `--exit`), adds prod build, adds test deps.
packages/bitcore-cli/package-lock.json	Locks new dev dependencies (BWS, mongodb, supertest, etc.).
packages/bitcore-cli/copyTestWallets	Adds helper script to copy wallet fixtures into build output for tests.

Files not reviewed (1)

packages/bitcore-cli/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 39 out of 42 changed files in this pull request and generated 10 comments.

Files not reviewed (2)

packages/bitcore-cli/package-lock.json: Language not supported
packages/bitcore-wallet-client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <copilot@github.com>

….die

Copilot

Pull request overview

Copilot reviewed 40 out of 43 changed files in this pull request and generated 7 comments.

Files not reviewed (2)

packages/bitcore-cli/package-lock.json: Language not supported
packages/bitcore-wallet-client/package-lock.json: Language not supported

…ds on wallet creation

…d infinite recursion

MichaelAJay · 2026-05-12T19:30:13Z

  const network = await getNetwork();
-  const isMultiParty = await getIsMultiParty();
+  // No solana support for multi-party wallets right now (TSS is ECDSA only)
+  const isMultiParty = chain === 'sol' ? false : await getIsMultiParty();


You chain.toLowerCase() in the file above - should do that here too just to be safe?

MichaelAJay · 2026-05-12T19:37:05Z


  const chain = await getChain();

+  if (chain === 'sol') {


same here - should be chain.toLowerCase()?

MichaelAJay · 2026-05-13T00:29:21Z

  }
 }

+export function difference(arr1: any[], arr2: any[]): any[] {


docs would be really nice here:
"Returns a new array of the elements in arr1 which are not in arr2"

MichaelAJay · 2026-05-13T00:58:44Z

+export function difference(arr1: any[], arr2: any[]): any[] {
+  arr1 = arr1 || [];
+  arr2 = arr2 || [];
+  const arr2Set = new Set(arr2);


Works fine for primitives, but Set.has() uses strict reference equality. Structurally identical objects are not considered equal - is that the desired behavior? That should maybe be specified in the docs too if so.

Run this script from bitcore root -

node - <<'NODE' const { difference } = require('./packages/crypto-wallet-core/ts_build/src/utils'); const arr1 = [{ a: 1 }, { b: 2 }]; const arr2 = [{ a: 1 }]; const diff = difference(arr1, arr2); // Many people would expect diff to ONLY include { b: 2 }, but it includes { a: 1 } as well. console.log(JSON.stringify(diff)); NODE

Here's a test which demonstrates the failure. That's assuming the intent is "structural equality" - same shape elements get filtered out.

it('should return objects not present in arr2 (structural equality)', () => { const result = difference( [{ a: 1 }, { b: 2 }], [{ a: 1 }], ); expect(result).to.deep.equal([{ b: 2 }]); });

Ran this test - it fails.

AssertionError: expected [ { a: 1 }, { b: 2 } ] to deeply equal [ { b: 2 } ] + expected - actual [ { - "a": 1 - } - { "b": 2 } ]

MichaelAJay · 2026-05-13T01:02:21Z

  }
 }

+export function difference(arr1: any[], arr2: any[]): any[] {


This feels like a great candidate for a TS generic. Tightens up the usage contract.

export function difference<T>(arr1: T[], arr2: T[]): T[]

MichaelAJay · 2026-05-13T01:37:33Z

+    const b = stack.pop();
+    if (a === b) continue;
+    if (a == null || b == null) return false;
+    if (typeof a !== 'object' || typeof b !== 'object') return false;


Should there be a specific a/b are Arrays check - or is that handled correctly downstream?

WIP - tests

16318fd

kajoseph added the bitcore-cli This pull request modifies the bitcore-cli package label Feb 12, 2026

kajoseph added 8 commits March 23, 2026 12:24

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

6e55ac3

rework txproposals view to use paginated controls for consistency

2d8729a

QoL: better complete handling, tweaked goodbyes

58856e0

WIP: tests

da709de

export constants from BWC

06502f3

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

afdc527

call done immediately on error

34a86f3

no color in CI output

3041647

kajoseph force-pushed the bitcoreCli branch from bb2db12 to 3041647 Compare March 30, 2026 20:07

kajoseph and others added 9 commits March 30, 2026 16:40

use testnet wallets in tests

67f9537

more helpful created line error

c1a30b7

fix proposal test timezone issue

bdf9c7f

add tests for filestorage, utils, prompts

6e13a55

add multisig creation tests

8c74249

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

4d970e2

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

74e9b01

gate multi-party wallet chains; tss creation tests; more wallet creat…

ffcc3ef

…ion tests

cleanup test output & fix walletId not being set

5c7b5cb

Co-authored-by: Copilot <copilot@github.com>

kajoseph requested a review from Copilot May 4, 2026 20:13

Copilot started reviewing on behalf of kajoseph May 4, 2026 20:14 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

kajoseph added 4 commits May 5, 2026 11:45

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

6b9adb6

fix sendMax

20849db

rm tsx from bwc

a5946eb

address copilot feedback

c89ff38

kajoseph requested a review from Copilot May 5, 2026 20:02

Copilot started reviewing on behalf of kajoseph May 5, 2026 20:03 View session

kajoseph added the BWC This pull request modifies the bitcore-wallet-client package label May 5, 2026

kajoseph added BWS This pull request modifies the bitcore-wallet-service package CWC This pull request modifies the crypto-wallet-core package labels May 5, 2026

Copilot AI reviewed May 5, 2026

View reviewed changes

kajoseph and others added 6 commits May 6, 2026 11:12

add utils tests, make isEqual more robust

5e00a1b

Co-authored-by: Copilot <copilot@github.com>

properly export types from BWC

961cbb4

fix Utils.die stub to throw instead of oddly throwing result of Utils…

d6c5091

….die

clearer page handling in paginator

b21cf29

fix typos; rm unneeded function

0f2fad9

handle missing dir in copyTestData

2091845

kajoseph requested a review from Copilot May 6, 2026 16:07

Copilot started reviewing on behalf of kajoseph May 6, 2026 16:08 View session

kajoseph marked this pull request as ready for review May 6, 2026 16:39

kajoseph requested review from MichaelAJay and Copilot and removed request for Copilot May 6, 2026 16:39

Copilot started reviewing on behalf of kajoseph May 7, 2026 14:39 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

kajoseph added 4 commits May 7, 2026 15:36

Merge branch 'master' of github.com:bitpay/bitcore into bitcoreCli

d61d10b

no throw Utils.die; clearer command inputs; better persistence of cre…

994af84

…ds on wallet creation

make copyTestData more portable

9b56c57

isEqual: handle implicit vs explicity undefined vals recursive + guar…

fecf7dc

…d infinite recursion

MichaelAJay reviewed May 12, 2026

View reviewed changes

MichaelAJay reviewed May 13, 2026

View reviewed changes

Conversation

kajoseph commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Testing Notes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaelAJay May 12, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 12, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 13, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelAJay May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kajoseph commented Feb 12, 2026 •

edited

Loading

MichaelAJay May 13, 2026 •

edited

Loading

MichaelAJay May 13, 2026 •

edited

Loading

MichaelAJay May 13, 2026 •

edited

Loading