matrix: add Electrum Wallet#2740
Conversation
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Sounds mostly plausible to me, except for where I commented. Are you associated with the Electrum project? Otherwise it might be good to have one of the Electrum contributors review this.
| hwi: "Yes" | ||
| default_receive: "P2WPKH" | ||
| bech32: "Full Support (send & receive)" | ||
| bech32m: "No Support" |
There was a problem hiding this comment.
According to whentaproot.org, Electrum should be able to send to P2TR ouputs.
| bech32m: "No Support" | |
| bech32m: "Send Support" |
There was a problem hiding this comment.
Good catch. Indeed, sending to bech32m is supported.
Force pushed the change: https://github.com/bitcoinops/bitcoinops.github.io/compare/9f4ef467f163c4a8cc2a55cf9cda4bd6e09e4ba1..91052d1fcc7d51ca968b568349d9dd461ad1cc48
yes, f321x is full time Electrum developer |
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clarification, @ecdsa.
| --- | ||
| name: "Electrum" | ||
| category: "Software Wallet (L1&L2)" | ||
| keyfeatures: "Fast and self-custodial wallet for Bitcoin and the Lightning Network with Hardware Wallet support and reproducible build system" |
There was a problem hiding this comment.
Looking at this again, maybe:
| keyfeatures: "Fast and self-custodial wallet for Bitcoin and the Lightning Network with Hardware Wallet support and reproducible build system" | |
| keyfeatures: "Fast, self-custodial wallet for Bitcoin and the Lightning Network with Hardware Wallet support and reproducible build system" |
There was a problem hiding this comment.
Yes that sounds better, thanks.
See https://github.com/bitcoinops/bitcoinops.github.io/compare/91052d1fcc7d51ca968b568349d9dd461ad1cc48..1b67db01c21296c4ab6573616a235945bc6c3b85
Adds the Electrum Bitcoin Wallet to the wallet matrix.
|
@TorokNRoll can you take a look? |
|
@bitschmidty I am back in the saddle. |
Great, let us know how it looks and tooling on your side. 👍 |
|
@TorokNRoll: Could you remind me what the best procedure is? If wallet developers submit their information as here, does it make sense to put it through your form or is this ready to be merged as is? |
5 participants
Adds the Electrum Bitcoin Wallet to the wallet matrix.
@ecdsa