fix(bitcoind_rpc): backport PR#2167#2198
Merged
evanlinjin merged 1 commit intoMay 9, 2026
Merged
Conversation
…e agreement point When a reorg drops the agreement point below `start_height`, the emitter would skip directly to `start_height`, producing a checkpoint that could not connect with the caller's local chain (`CannotConnectError`). Fix: override `start_height` to the agreement height when a reorg is detected (agreement point below both `start_height` and `last_cp`), so the emitter revisits the invalidated block heights.
oleonardolima
added
bug
evanlinjin
merged commit 2efbfcf
into
bitcoindevkit:release/chain-0.23.x
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's a backport for the the
bdk_bitcoind_rpcfix introduced by #2167. If you're interested in the original fix, check the original PR for discussion/rationale.Notes to the reviewers
The introduced tests needs a review, as I had to update it use the older Emitter and TestEnv APIs.
Changelog notice
Checklists
All Submissions:
Bugfixes: