Skip to content

BIP-376: add python ref implementation and initial test vectors #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucia-w wants to merge 5 commits into
base: master
Choose a base branch
from
Open

BIP-376: add python ref implementation and initial test vectors #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
652b940
This fills in the remaining TODO sections in BIP-376
lucia-w May 9, 2026
b0b2cf4
BIP-0376: use PSBT vectors for signer tests
lucia-w May 9, 2026
9ebb27f
bip-0376: remove error message checks from invalid vectors
lucia-w May 9, 2026
58a43d4
BIP-0376: use PSBT vectors for signer tests
lucia-w May 9, 2026
b718f2e
bip-0376: vendor test deps and add PSBTv2 vectors
lucia-w May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions bip-0376.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,30 @@ These are new fields added to the existing PSBT format. Because PSBT is designed

== Reference implementation ==

'''''TODO'''''
A Python reference implementation is provided in [[bip-0376/reference.py|<code>bip-0376/reference.py</code>]].
It uses the vendored <code>bitcoin_test</code> PSBT components and <code>secp256k1lab</code> test-only secp256k1 implementation from BIP 375.

It demonstrates the Signer behavior specified in this BIP:

* Key derivation using ''d = (b<sub>spend</sub> + tweak) mod n''.
* Key negation when ''d·G'' has odd y-coordinate.
* Verification that the resulting x-only public key matches the output key ''P''.
* BIP 340 signing with the derived key.
Comment on lines +152 to +157
Copy link
Copy Markdown
Contributor

@nymius nymius May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated.


=== Test vectors ===

'''''TODO'''''
Machine-readable test vectors are provided in [[bip-0376/test-vectors.json|<code>bip-0376/test-vectors.json</code>]].

The vector set includes:

* Valid signing cases with and without key negation.
* Invalid cases for output-key mismatch, zero tweaked key, and out-of-range spend key.

Copy link
Copy Markdown
Contributor

@nymius nymius May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated too. I would use the test cases descriptions here, flagging each test case as valid or invalid.

The reference implementation can be run against the vectors with:

<pre>
./bip-0376/reference.py bip-0376/test-vectors.json
</pre>

== Appendix ==

Expand Down
Loading