Skip to content

Migrate macos jobs to macos_arm64#173

Open
ted-xie wants to merge 1 commit into
bazelbuild:masterfrom
ted-xie:no_macos_android
Open

Migrate macos jobs to macos_arm64#173
ted-xie wants to merge 1 commit into
bazelbuild:masterfrom
ted-xie:no_macos_android

Conversation

@ted-xie

@ted-xie ted-xie commented Jun 16, 2026

Copy link
Copy Markdown

The Intel macos deployment in BazelCI does not have the latest Android build tools installed. By default, BazelCI adds ANDROID* environment variables to builds, which registers an Android toolchain for any transitively-loaded Android deps, which causes a repo rule-level error.

To prevent this, this PR migrates macos jobs to macos_arm64.

@ted-xie

ted-xie commented Jun 16, 2026

Copy link
Copy Markdown
Author

NOTE: An alternative is to change the BazelCI platform from macos to macos_arm64.

@hvadehra

Copy link
Copy Markdown
Member

Why are we polluting rules repo configs if the issue is in how Bazel CI is configured/deployed? Surely we should instead just not set these vars in bazelci.py when the platform is macos?

@ted-xie

ted-xie commented Jun 17, 2026

Copy link
Copy Markdown
Author

I would argue that it's also not good to specialize BazelCI to do special behavior for just one platform-type due to technical limitations of the underlying system. WDYT about this instead:

NOTE: An alternative is to change the BazelCI platform from macos to macos_arm64.

AFAIK there's no real need for rules_testing to test on Intel Macs specifically, and the arm64 Macs in BazelCI are faster.

@ted-xie ted-xie force-pushed the no_macos_android branch from 152816e to 621fc20 Compare June 18, 2026 20:14
@ted-xie ted-xie changed the title Null-out Android env for non-Android macos builds Migrate macos jobs to macos_arm64 Jun 18, 2026
@ted-xie

ted-xie commented Jun 18, 2026

Copy link
Copy Markdown
Author

Changed the scope of this PR to migrate macos to macos_arm64, which is faster in BazelCI anyway.

@hvadehra hvadehra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do you know when you expect things to start failing without this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants