Skip to content

Stop removing AR from macOS env#4083

Closed
keith wants to merge 1 commit into
bazelbuild:mainfrom
keith:ks/stop-removing-ar-from-macos-env
Closed

Stop removing AR from macOS env#4083
keith wants to merge 1 commit into
bazelbuild:mainfrom
keith:ks/stop-removing-ar-from-macos-env

Conversation

@keith

@keith keith commented Jun 12, 2026

Copy link
Copy Markdown
Member

With bazelbuild/apple_support#601 we make our
libtool wrapper normalize ar arguments so we can handle this case and
still produce hermetic archives (which Apple's ar does not)

With bazelbuild/apple_support#601 we make our
libtool wrapper normalize ar arguments so we can handle this case and
still produce hermetic archives (which Apple's ar does not)
@keith

keith commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

im submitting this as documentation but im not sure it's really mergable since different toolchains could have different capabilities here

@UebelAndre

Copy link
Copy Markdown
Collaborator

You could introduce an incompatible flag for this to nudge folks over to upgrading their toolchains

@keith

keith commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

but they could also use a non-apple_support toolchain which wouldn't help this, like using @llvm / toolchains_llvm / the raw rules_cc toolchain

@UebelAndre

Copy link
Copy Markdown
Collaborator

but they could also use a non-apple_support toolchain which wouldn't help this, like using @llvm / toolchains_llvm / the raw rules_cc toolchain

Couldn't they constrain their toolchains on that? But that direction aside, how can I help move this forward?

@keith

keith commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

the more i think about it i think the only option is to remove libtool from the name of our wrapper since multiple places use libtool to differentiate this, and the executable could still be a libtool where this logic is needed

@keith keith closed this Jun 12, 2026
@keith keith deleted the ks/stop-removing-ar-from-macos-env branch June 12, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants