fix(tar): drop truthy-string default on store_true argparse flags#1065
Merged
Conversation
The `--preserve_mode` and `--preserve_mtime` flags in `pkg/private/tar/build_tar.py` were declared with `default='False'` (a string, which is truthy) combined with `action='store_true'`. When the flags are not passed on the command line, argparse uses the default verbatim instead of the boolean `False` that `store_true` would produce, so `options.preserve_mode` and `options.preserve_mtime` end up as the string `'False'` — truthy under any natural truthy check. rules_pkg's own use happens to be safe because the check is `if self.preserve_mode is True`, but the typo is a foot-gun for anyone copying the pattern. Drop the bogus default — `action='store_true'` already defaults to boolean `False`. Fixes bazelbuild#1064
cgrindel
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--preserve_modeand--preserve_mtimeflags inpkg/private/tar/build_tar.pywere declared withdefault='False'(a string, which is truthy) combined withaction='store_true'. When the flags are not passed,options.preserve_mode/options.preserve_mtimeend up as the string'False'rather than the booleanFalse— truthy under any natural truthy check.Dropping
default='False'is sufficient:action='store_true'already defaults to booleanFalseon its own.Fixes #1064