Skip to content

feat: Add bashIde.shfmt.additionalArguments LSP setting.#1387

Open
kylechui wants to merge 2 commits into
bash-lsp:mainfrom
kylechui:main
Open

feat: Add bashIde.shfmt.additionalArguments LSP setting.#1387
kylechui wants to merge 2 commits into
bash-lsp:mainfrom
kylechui:main

Conversation

@kylechui

@kylechui kylechui commented Jul 3, 2026

Copy link
Copy Markdown

This will allow a user to extend the arguments being passed to the shfmt binary, and resolve #1385.

NOTE: I think that some of the tests had their number of arguments increased by one, since my wrapper makeShfmtConfig will impute languageDialect: 'auto' when it used to be omitted.

This will allow a user to extend the arguments being passed to the shfmt
binary, and resolve bash-lsp#1385.
@kylechui kylechui marked this pull request as draft July 3, 2026 15:18
@kylechui

kylechui commented Jul 3, 2026

Copy link
Copy Markdown
Author

The tests are largely passing my local machine, except for a few that rely on the get-options.sh script. I think this is because I am running NixOS, which doesn't store those completion files in the Linux FHS. I imagine if the CI for this project has tests that spin up the language server in a virtual machine, then they should pass.

@kylechui kylechui marked this pull request as ready for review July 3, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow multi-argument commands to start up shfmt

1 participant