Retry on throttle and quota errors in integ test#59
Open
Alan4506 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
test_get_medical_scribe_streamintegration test previously only retried onBadRequestException(IAM role propagation delay). When multiple test runs execute concurrently against the same account, the test can also encounter:LimitExceededException: post-stream analytics job quota exceededThrottlingException(surfaced asCallError): concurrent streaming session limit exceededThis change adds retry handling for both cases. The
ThrottlingExceptionis not modeled in the service's error registry, so it arrives as a genericCallError, and we match it by error id in the message string.Testing:
Without these changes, running 20 concurrent instances of integration tests:
results in failures with
LimitExceededExceptionandCallError: Unknown error ... ThrottlingException. With the fix applied, 20/20 concurrent runs pass.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.