fix: make torch an optional dependency in sagemaker-core#5756
Draft
matteociccozzi-ah wants to merge 1 commit intoaws:masterfrom
Draft
fix: make torch an optional dependency in sagemaker-core#5756matteociccozzi-ah wants to merge 1 commit intoaws:masterfrom
matteociccozzi-ah wants to merge 1 commit intoaws:masterfrom
Conversation
torch>=1.9.0 was a hard dependency despite only being used by TorchTensorSerializer and TorchTensorDeserializer. Moved to optional-dependencies[torch]. Added proper ImportError handling with actionable install hint in both classes and unit tests for the ImportError path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matteociccozzi-ah
requested a deployment
to
manual-approval
GitHub Actions
Waiting
matteociccozzi-ah
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch>=1.9.0was declared as a hard dependency insagemaker-core/pyproject.tomldespite only being used byTorchTensorSerializerandTorchTensorDeserializer. This forcedtorch(a multi-GB package) onto all consumers ofsagemaker-core, including those with no PyTorch workloads.torchto[project.optional-dependencies]under thetorchextra — install withpip install sagemaker-core[torch]ImportErrorhandling with an actionable message in both classes (the serializer had no error handling at all; the deserializer raised a bareException)ImportErrorpath in both classes