[1.0] Fix build: remove callSite from OpenVSX verification request#263
Merged
Conversation
| +++ code-editor-src/src/vs/platform/extensionManagement/common/extensionGalleryService.ts | ||
| @@ -680,6 +680,7 @@ export abstract class AbstractExtensionG | ||
| --- a/src/vs/platform/extensionManagement/common/extensionGalleryService.ts | ||
| +++ b/src/vs/platform/extensionManagement/common/extensionGalleryService.ts |
Contributor
There was a problem hiding this comment.
Shouldn't this be code-editor
Contributor
Author
There was a problem hiding this comment.
It wouldn't matter but let me change it for consistency with other patches. Good catch!
callSite property does not exist on IRequestOptions in Code-OSS 1.101. This was causing a TypeScript compilation error on the 1.0 branch.
sachinh-amazon
force-pushed
the
fix/openvsx-callsite-1.0
branch
from
6510616 to
43c5e68
Compare
aakashmandavilli96
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
callSiteproperty from the request object inadd-openvsx-verification-check.diff. This property doesn't exist onIRequestOptionsin Code-OSS 1.101, causing TS6133 compilation failure. The verification logic is unchanged.