fix(extensions-sync): Auto-repair dangling symlinks on SMD image upgrade#247
Merged
Merged
Conversation
Add repairDanglingSymlinks() to detect and fix broken symlinks in the persistent volume when a CodeEditor space restarts with a newer SMD image. Runs before existing sync logic so subsequent reads see clean state. Respects .obsolete file to avoid re-installing user-uninstalled extensions.
pilgd-aws
force-pushed
the
fix/repair-dangling-symlinks
branch
from
f25d005 to
30b8a7b
Compare
skazantsev
approved these changes
Jun 16, 2026
Contributor
|
Does this need to be backported to existing release channels (1.1, 1.0)? |
Contributor
Author
We only have to ship with newest code editor. Let me know if merging just to main is not sufficient. |
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
repairDanglingSymlinks()to thesagemaker-extensions-syncextension. When a CodeEditor space restarts with a newer SMD image, pre-packaged extension symlinks become dangling (old version paths no longer exist). This fix detects and re-links them automatically before the existing sync logic runs.What it does
stat()fails (dangling).obsoletefile to avoid re-installing user-uninstalled extensionsrefreshExtensionsMetadata()to force VS Code rescanTesting
Change size
90 insertions, 3 deletions in
patches/sagemaker/sagemaker-extensions-sync.diff