feat(sdk): monorepo repository to add new otel plugin package#397
Open
SilanHe wants to merge 3 commits into
Open
feat(sdk): monorepo repository to add new otel plugin package#397SilanHe wants to merge 3 commits into
SilanHe wants to merge 3 commits into
Conversation
SilanHe
force-pushed
the
feat/add-otel-package
branch
from
3b74d87 to
7bded69
Compare
SilanHe
commented
May 22, 2026
Contributor
Author
There was a problem hiding this comment.
I haven't actually tested this one but it looks quite reasonable. I had to work a little more closely with AI on this one.
zhongkechen
reviewed
May 26, 2026
| # SPDX-FileCopyrightText: 2025-present Amazon.com, Inc. or its affiliates. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| __version__ = "0.1.0" |
Contributor
There was a problem hiding this comment.
Should we start with the same version as the SDK?
Contributor
There was a problem hiding this comment.
examples worth its own package. We can do this later.
| - name: Run tests + coverage | ||
| run: hatch run test:cov | ||
| run: | | ||
| for pkg in packages/*/; do |
Contributor
There was a problem hiding this comment.
Does the order matter when running tests/build?
| if [ -f "$pkg/pyproject.toml" ]; then | ||
| echo "=== Building: $pkg ===" | ||
| cd "$pkg" | ||
| hatch build |
Contributor
There was a problem hiding this comment.
how does this build rely on a local version of the other package instead of a version from pypi?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Monorepo Restructure
The repo was converted from a single-package layout to a monorepo with a
packages/directory:src/,tests/,examples/,pyproject.toml) intopackages/aws-durable-execution-sdk-python/New Package: OpenTelemetry Instrumentation
A new package was added at
packages/aws-durable-execution-sdk-python-otel/(v0.1.0):pyproject.tomlopentelemetry-api≥1.20.0,opentelemetry-sdk≥1.20.0__init__.py__version__only, no instrumentation logic yet)README.mdinstrument_durable_execution()) and featurestests/py.typedCI & Workflow Updates
ci.yml— Loops over allpackages/*/directories for format checks, type checking, tests, and buildsci-checks.sh— Iterates over aPACKAGESarray instead of running checks at the repo rootpypi-publish.yml— Uses a matrix strategy to build and publish each package independently; per-package artifact namessync-package.yml— Deleted (no longer needed)deploy-examples.yml/integration-tests.yml— Minor path adjustmentsDocumentation
CONTRIBUTING.mdcdinto package dirs before running hatchRELEASING.md(new)sdk-vX.Y.Z,otel-vX.Y.Z), PyPI publishing flow, release notes format, pre-publish checklistREADME.md(new)Misc
.gitignore— Relaxed example build/zip patterns from root-anchored to relative (works with nested layout)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.