fix(tui): use "No memory" instead of "Disabled" in harness memory picker#1635
Merged
Conversation
The harness memory-mode picker and confirm summary labeled the opt-out
option "Disabled". Per Amazon's inclusive-language guidance, replace the
displayed label with "No memory" (matching the agent/generate wizard,
which already uses "None" / "No memory").
Display-only change. The option id, config value { mode: 'disabled' },
the --memory-mode disabled flag, and the CFN Memory: { Disabled: {} }
mapping are wire/API contracts and are deliberately left unchanged.
Closes #1634
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1635-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz |
avi-alpert
approved these changes
Jun 24, 2026
agentcore-cli-automation
approved these changes
Jun 24, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Display-only rename is well-scoped: the contract id: 'disabled' is preserved, and the picker only consumes id/title/description (verified at AddHarnessScreen.tsx:130), so the schema, CFN Memory: { Disabled: {} } mapping, --memory-mode disabled flag, and deploy notices are untouched. Grepped for other references to the old 'Disabled' string in harness tests and snapshots — none found, so no test/snapshot updates are required. No telemetry implications for a display-string change. Aligns the harness wizard wording with the existing generate wizard (generate/types.ts:197).
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the harness add/create TUI wizard, the memory-mode picker presented its opt-out option with the label
Disabled, and the confirm-review summary showedMemory: Disabled.This PR changes the displayed label only to
No memory, matching the agent/generate wizard which already usesNone/ "No memory".Changes:
src/cli/tui/screens/harness/types.ts—MEMORY_MODE_OPTIONSopt-out optiontitle: 'Disabled'→'No memory'; description trimmed to'Default'(was'No memory (default)') to avoid duplicating the new title.src/cli/tui/screens/harness/AddHarnessScreen.tsx— confirm-review summary value'Disabled'→'No memory'.Deliberately NOT changed (wire/API contracts): the option
id: 'disabled', the config union{ mode: 'disabled' }, the Zodz.literal('disabled'), the--memory-mode disabledflag value and its help text /VALID_MEMORY_MODESallow-list, the deploy notices that instruct users to type--memory-mode disabled, and the CDKMemory: { Disabled: {} }CFN mapping. Renaming any of these would break deployments or the schema shared with@aws/agentcore-cdk.The picker's
onSelectconsumes onlyitem.id(neveritem.title), so the title is pure presentation and is never parsed back — which is why this rename is safe.Related Issue
Closes #1634
Documentation PR
N/A — no doc changes.
docs/memory.mdalready describes the agent--memory noneshorthand as "No memory resource created"; no harness--memory-modeprose references a "Disabled" display label.Type of Change
Testing
How have you tested the change?
npm run test:unit(harness suite:src/cli/tui/screens/harness— 6/6 passed, including the contract testmaps disabled to a bare disabled option)npm run typecheck(exit 0)npm run lint(0 errors on the changed files; 2 pre-existing warnings unrelated to this change)src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots (N/A — no asset changes)No test or snapshot asserts the changed display strings, so none required updating. The contract value
{ mode: 'disabled' }remains covered and green.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.