Skip to content

fix(run-insights): reject empty --name "" instead of auto-generating #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notgitika wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(run-insights): reject empty --name "" instead of auto-generating #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cli/commands/run/command.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,13 +398,17 @@ export const registerRun = (program: Command) => {
if (!cliOptions.json) console.log(message);
};

if (cliOptions.name?.trim() === '') {
throw new ValidationError('--name must not be empty. Omit the flag to auto-generate a name.');
}

@agentcore-cli-automation agentcore-cli-automation Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is outside runCliCommand, which breaks two things:

  1. Telemetry: runCliCommand records failures via trackCommandRun (src/cli/telemetry/cli-command-run.ts). Throwing here bypasses that, so this validation failure is never emitted as a cli.command_run event. Per src/cli/telemetry/README.md, validation errors should be thrown inside the wrapper.

  2. --json output contract: runCliCommand formats errors as { success: false, error: ... } on stdout when --json is set. Throwing outside means Commander's default handler prints plain text to stderr, so agentcore run insights --name "" --json won't produce parseable JSON.

The fix is to move this block inside the runCliCommand callback (a few lines below), next to the existing --lookback-days validation. That's the same pattern used by run ingest at line 672-674.

await runCliCommand('run.job', !!cliOptions.json, async () => {
  if (cliOptions.name !== undefined && cliOptions.name.trim() === '') {
    throw new ValidationError('--name must not be empty. Omit the flag to auto-generate a name.');
  }
  const engine = createJobEngine(new ConfigIO());
  // ...


await runCliCommand('run.job', !!cliOptions.json, async () => {
const engine = createJobEngine(new ConfigIO());

const insightIds = cliOptions.insights ?? ['Builtin.Insight.FailureAnalysis'];
const lookbackDays = cliOptions.lookbackDays ? parseInt(cliOptions.lookbackDays, 10) : undefined;
if (lookbackDays !== undefined && (isNaN(lookbackDays) || lookbackDays < 1 || lookbackDays > 90)) {
throw new Error('--lookback-days must be between 1 and 90');
throw new ValidationError('--lookback-days must be a positive integer between 1 and 90.');
}

const startResult = await engine.start('insights', {
Expand Down
Loading