Esp32 i2c simtests and fixes#2302
Open
petermm wants to merge 2 commits into
Open
Conversation
Track open/closed I2C NIF resource state, clean up command handles on error paths, and reject closes while a transmission is active. Ensure driver-delete failures do not leave the resource half-closed, and document the ESP32 I2C fixes in the changelog. Signed-off-by: Peter M <petermm@gmail.com>
Wire a BMP180 into the ESP32 Wokwi simulator and add an Erlang test that exercises I2C through both port-driver and NIF paths. Cover successful sensor reads, NACK recovery, split transactions, and ownership-contention errors. Signed-off-by: Peter M <petermm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds i2c simtest on esp32, this in preparation for adding the newer i2c esp-idf driver soon.
Includes fixes for various issues surfaced:
fix i2c resource cleanup after close
fix i2c half-closed state when driver delete fails
reject i2c close during active transmission
fix i2c cmd handle leaks on error paths
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later