Test to illustrate thrown exception (new domain entity)#13
Open
ElGigi wants to merge 10 commits into
Open
Conversation
Contributor
Author
|
I added a fix |
Contributor
Author
|
Any news? Thanks. |
|
|
||
|
|
||
| // Test new entity | ||
| $newFakeEntity = new Fake(new Email('fake@example.com'), |
There was a problem hiding this comment.
Your changes are related to the EntityHandler but this is the test class for a value object. Is this correct?
Contributor
Author
There was a problem hiding this comment.
Yes because it's on the persist of a ValueObject.
There was a problem hiding this comment.
Two suggestions for the test:
- Create a separate test method and use a name that describes the current testing process.
- At the moment the test did not perform any assertions, that should be changed.
Contributor
Author
|
Any news? Project abandoned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue explain here:
#10