Fix race condition when wait_for_event is used at the same time as direction_up etc.#155
Open
aonghusonia wants to merge 2 commits into
Open
Fix race condition when wait_for_event is used at the same time as direction_up etc.#155aonghusonia wants to merge 2 commits into
aonghusonia wants to merge 2 commits into
Conversation
… same time raise error if using wait_for_event when callbacks are assigned.
Clarify usage restrictions for joystick functions and events.
Author
|
This code replicates the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you already have a callback assigned to one of the directions ot any and you wait_for_event the first press gets ignored because its read by the callback.
wait_for_event now raises an error if there is a joystick callback assigned. Also added a warning to the documentation