fix: handling of larger asdf info outputs#197
Merged
Conversation
Came up in the case of reading a Roman L2 ASDF file (asdf-formatgh-191) but is not specific to it. Fixes two issues: - Truncate long scalar values in the output - Double free / dangling pointers on the `active_levels` array; this array is meant to be reused by all node levels (it just tracks when printing a line which levels of indent should have a vertical pipe drawn) but if it gets resized during tree traversal the resized active_levels pointer was left dangling on previous node levels; this ensures that they are all sharing the same reference to a node_indent_t structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up in the case of reading a Roman L2 ASDF file (gh-191) but is not specific to it. Fixes two issues:
active_levelsarray; this array is meant to be reused by all node levels (it just tracks when printing a line which levels of indent should have a vertical pipe drawn) but if it gets resized during tree traversal the resized active_levels pointer was left dangling on previous node levels; this ensures that they are all sharing the same reference to a node_indent_t structure.Resolves #191