Create ImageResource conforming to ManagedResource#1619
Merged
jglogan merged 2 commits intoJun 2, 2026
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
Code Coverage
|
jglogan
reviewed
May 31, 2026
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
jglogan
reviewed
Jun 1, 2026
|
|
||
| try Output.emit(Output.renderJSON(printable)) | ||
| let options = JSONOptions( | ||
| outputFormatting: [.prettyPrinted, .sortedKeys], |
Contributor
There was a problem hiding this comment.
Suggested change
| outputFormatting: [.prettyPrinted, .sortedKeys], | |
| outputFormatting: [.sortedKeys], |
We weren't pretty printing anywhere else except VolumeInspect.
Let's choose to do either this, or I can change the network/volume PR currently open to pretty print on inspect.
Contributor
There was a problem hiding this comment.
Let's merge this, and then we'll do the following in #1624:
- sortedKeys and ISO timestamps everywhere
- pretty printed for resource
inspect
jglogan
reviewed
Jun 1, 2026
| let fullSize: String | ||
| let descriptor: Descriptor | ||
| private static func emitJSON(resources: [ImageResource]) throws { | ||
| let options = JSONOptions(dateEncodingStrategy: .iso8601) |
jglogan
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Testing