Skip to content

test: mark test_infinite_scroll_on_dynamic_page as flaky#2072

Open
vdusek wants to merge 1 commit into
masterfrom
test/mark-infinite-scroll-windows-flaky
Open

test: mark test_infinite_scroll_on_dynamic_page as flaky#2072
vdusek wants to merge 1 commit into
masterfrom
test/mark-infinite-scroll-windows-flaky

Conversation

@vdusek

@vdusek vdusek commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

test_infinite_scroll_on_dynamic_page intermittently fails on the windows-latest unit-test job. Under pytest-xdist load the Windows runner transiently runs out of socket buffer space (WSAENOBUFS), so page.goto to the local test server fails with net::ERR_NO_BUFFER_SPACE. The failure happens during navigation setup, before infinite_scroll (the code under test) ever runs, so it's an environmental flake rather than a product or test-logic defect.

This mirrors the repo's established convention for the same signature (test_browser_pool.py, test_stagehand_browser_controller.py, test_adaptive_playwright_crawler.py): mark the test with @pytest.mark.flaky(reruns=3, reason=...). The test's assertions stay deterministic given a successful navigation, so a real regression still fails all attempts; the reruns only absorb transient connection failures.

Failing run: https://github.com/apify/crawlee-python/actions/runs/29315899194/job/87029744185

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Jul 14, 2026
@vdusek vdusek self-assigned this Jul 14, 2026
@vdusek vdusek changed the title test: mark test_infinite_scroll_on_dynamic_page as flaky on Windows test: mark test_infinite_scroll_on_dynamic_page as flaky Jul 14, 2026
@vdusek vdusek marked this pull request as ready for review July 14, 2026 12:40
@vdusek vdusek requested a review from Pijukatel July 14, 2026 12:40
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.32%. Comparing base (e846690) to head (b46190a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   93.34%   93.32%   -0.03%     
==========================================
  Files         179      179              
  Lines       12496    12496              
==========================================
- Hits        11665    11662       -3     
- Misses        831      834       +3     
Flag Coverage Δ
unit 93.32% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants