test: mark test_infinite_scroll_on_dynamic_page as flaky#2072
Open
vdusek wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
- Coverage 93.34% 93.32% -0.03%
==========================================
Files 179 179
Lines 12496 12496
==========================================
- Hits 11665 11662 -3
- Misses 831 834 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_infinite_scroll_on_dynamic_pageintermittently fails on thewindows-latestunit-test job. Underpytest-xdistload the Windows runner transiently runs out of socket buffer space (WSAENOBUFS), sopage.gototo the local test server fails withnet::ERR_NO_BUFFER_SPACE. The failure happens during navigation setup, beforeinfinite_scroll(the code under test) ever runs, so it's an environmental flake rather than a product or test-logic defect.This mirrors the repo's established convention for the same signature (
test_browser_pool.py,test_stagehand_browser_controller.py,test_adaptive_playwright_crawler.py): mark the test with@pytest.mark.flaky(reruns=3, reason=...). The test's assertions stay deterministic given a successful navigation, so a real regression still fails all attempts; the reruns only absorb transient connection failures.Failing run: https://github.com/apify/crawlee-python/actions/runs/29315899194/job/87029744185