9.2.x: http2: Track scheduled events#13377
Open
bneradt wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to the 9.2.x branch that tracks scheduled HTTP/2 connection “xmit” events so they can be canceled during teardown, preventing rare use-after-free crashes when events fire after the continuation has been freed.
Changes:
- Add
_xmit_eventsto trackHTTP2_SESSION_EVENT_XMITscheduledEvent*instances. - Cancel all tracked xmit events during
Http2ConnectionState::destroy(). - Remove xmit events from the tracking container when they fire, and record new schedule_imm_local results.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proxy/http2/Http2ConnectionState.h | Adds _xmit_events member to track scheduled xmit events. |
| proxy/http2/Http2ConnectionState.cc | Pushes scheduled xmit events into _xmit_events, erases on callback, and cancels outstanding xmit events in destroy(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* http2: Track scheduled events * Handle events on state_closed
bneradt
force-pushed
the
backport-11262-9.2.x
branch
from
c6f97ff to
c263c57
Compare
masaori335
approved these changes
Jul 14, 2026
masaori335
left a comment
masaori335
left a comment
Contributor
There was a problem hiding this comment.
It's pretty different from 10.0.x, but the concept is the same - tracking scheduled events and cancel it on destructor.
github-project-automation
Bot
moved this from In progress
to Ready to Merge
in 9.2.x Branch and Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #11262 because it fixes some rare crashes seen without
it.
Possible fix of #11260. Scheduled events should be tracked and canceled by destructor. Otherwise, scheduled events will be fired to the freed continuation.