RANGER-5607 issue in put plugins/services/id#984
Open
abhiishek26 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
the api put plugins/services/{id} implemented in ServiceREST updateService. do not appropriately throws error when the service name field is left blank in the payload or mismatch between ids passed through payload and request url .
I compared this with the put apis present in ServiceREST and other modules there appropriate id mismatch or name absent errors are handled .
I have made changes in the implementation to properly handle those scenarios .
How was this patch tested?
All the unit tests were passed locally and the bulild (mvn clean install , mvn clean test ) successfully passed
2 unit tests have been implemented to simulate id mismatch and servicename absent in payload scenarios