Skip to content

reset graphics state in PDFPrintable.print method #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valerybokov wants to merge 4 commits into from
+7 −6
Closed

reset graphics state in PDFPrintable.print method #443

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ddee64
reset graphics state in PDFPrintable.print method
valerybokov Apr 16, 2026
3af0668
reset transform in PDFPrintable.print method
valerybokov Apr 17, 2026
2cb97d3
delete unneeded check in PDPrintable.print
valerybokov May 8, 2026
5358e96
work on copy of the caller;'s graphics in PDPrintable.print
valerybokov May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pdfbox/src/main/java/org/apache/pdfbox/printing/PDFPrintable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,14 @@ public int print(Graphics graphics, PageFormat pageFormat, int pageIndex)
return NO_SUCH_PAGE;
}

Graphics2D printerGraphics = null;
Graphics2D graphics2D = null;
// work on a private copy so the caller's Graphics2D state (transform, clip, color,
// background, stroke) is never mutated. Disposing the copy in the finally block
// releases its resources without affecting the original.
Graphics2D printerGraphics = (Graphics2D) graphics.create();
Graphics2D graphics2D = printerGraphics;

try
{
printerGraphics = (Graphics2D) graphics;
graphics2D = printerGraphics;

// capture the DPI that will be used for rasterizing the image
// if rasterizing is specified
float rasterDpi = dpi;
Expand Down Expand Up @@ -324,10 +324,11 @@ public int print(Graphics graphics, PageFormat pageFormat, int pageIndex)
}
finally
{
if (graphics2D != null && graphics2D != printerGraphics)
if (graphics2D != printerGraphics)
{
graphics2D.dispose();
}
printerGraphics.dispose();
}
}

Expand Down