chore: upgrade DataFusion to 54#453
Merged
JingsongLi merged 1 commit intoJul 5, 2026
Merged
Conversation
5951160 to
685ce57
Compare
leaves12138
approved these changes
Jul 5, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed the DataFusion 54 upgrade. The code changes look like straightforward API migrations for provider/downcast hooks, ExecutionPlan::partition_statistics, SQL parser insert column handling, and the Python UDF wrapper.
Validation I ran locally:
cargo fmt --all -- --checkcargo clippy -p paimon-datafusion --all-targets -- -D warningscargo test -p paimon-datafusion --lib -- ...(186 passed; skipped 7 tests that require the external Spark-provisioned/tmp/paimon-warehousefixture)cargo test -p paimon-datafusion --test pk_tables test_pk_insert_overwrite_with_after_columns_reorder -- --nocapturecargo test -p paimon-datafusion --test merge_into_tests test_merge_insert_reordered_columns -- --nocapturePYO3_NO_PYTHON=1 PYO3_BUILD_EXTENSION_MODULE=1 cargo check -p pypaimon_rust --libPYO3_NO_PYTHON=1 PYO3_BUILD_EXTENSION_MODULE=1 cargo clippy -p pypaimon_rust --lib -- -D warnings
Notes:
- A full
cargo test -p paimon-datafusion --all-targetsneeds the pre-provisioned warehouse fixture locally; without it, the fixture-dependent scan tests fail withTableNotExist. - The Python Rust unit tests need a dynamic Python >= 3.10 for PyO3 auto-initialize; this environment only has static Python 3.10 and dynamic Python 3.8, so I validated the extension-module build and clippy path instead.
git diff --checkreports trailing whitespace in generatedDEPENDENCIES.rust.tsvfiles, which appears to come from trailing TSV columns.
No blocking issues found.
685ce57 to
5cb3a80
Compare
5cb3a80 to
8912db3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the DataFusion integration to DataFusion 54.0.0 and refresh the generated Rust dependency metadata. This also updates the SQL documentation to reflect the current DataFusion-delegated SQL surface and the Paimon-specific SQL support implemented by
SQLContext.Changes
datafusionanddatafusion-ffidependencies to 54.0.0.datafusion==54.0.0so Python DataFusion FFI matches the Rustdatafusion-ffiversion.INSERT OVERWRITE ... PARTITIONexplicit column handling for the DataFusion 54 SQL AST shape.DEPENDENCIES.rust.tsvfiles.integrationjob into parallel matrix shards:rust,datafusion,lumina,python, andgo.docs/src/sql.mdfor DataFusion 54 SQL support, Paimon-specific DDL/DML support, positiveLIKEpushdown, lateralvector_searchjoins, async catalog registration examples, and a broken DataFusion docs anchor.Testing
cargo fmt --all -- --checkmkdocs build -f docs/mkdocs.yml --strictcargo test -p paimon-datafusion --test sql_context_tests test_show_tables_is_enabledcargo test -p paimon-datafusion --test delete_tests test_delete_data_evolution_table_with_deletion_vectorscargo test -p paimon-datafusion --test merge_into_tests test_when_matched_delete_with_deletion_vectorscargo test -p paimon-datafusion --test read_tables -- --skip vector_search_tests::test_vector_search_top3 --skip vector_search_tests::test_vector_search_top6_returns_allcargo test -p pypaimon_rustuv lock --checkinbindings/pythonmake install && uv run --no-sync pytest tests/test_datafusion.py::test_query_simple_table_via_catalog_providerinbindings/pythonmake testinbindings/python.github/workflows/ci.ymllocally and verified the integration matrix containsrust,datafusion,lumina,python, andgogit diff --check -- .github/workflows/ci.yml bindings/python/pyproject.toml bindings/python/uv.lockNotes
A local full
cargo test -p paimon-datafusionrun passes the rest of the suite but cannot complete two vector search tests without the Lumina native library:vector_search_tests::test_vector_search_top3vector_search_tests::test_vector_search_top6_returns_allBoth fail locally with
Failed to load lumina library from 'liblumina_py.dylib';liblumina_py.dylibwas not present on this machine, andLUMINA_LIB_PATHis not set. CI installslumina-databefore the DataFusion and Lumina integration shards.