-
Notifications
You must be signed in to change notification settings - Fork 75
expose table observability API for pypaimon_rust #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SML0127
wants to merge
8
commits into
apache:main
Choose a base branch
from
SML0127:issue-285
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+466
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
67b147f
add partition_stats and list_partitions
SML0127 2b49fae
expose table observability api
SML0127 2f6ee49
add tests for observability
SML0127 d8289ce
fix: address PR #307 feedback
SML0127 a3cc911
fix
SML0127 4da2a9c
resolve comments
SML0127 968b881
fix: use BTreeMap for deterministic partition ordering
SML0127 326706e
resolved ci error
SML0127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use std::collections::HashMap; | ||
|
|
||
| use paimon::table::PartitionStat; | ||
| use pyo3::prelude::*; | ||
|
|
||
| #[pyclass(name = "PartitionStat", module = "pypaimon_rust.datafusion")] | ||
| pub struct PyPartitionStat { | ||
| inner: PartitionStat, | ||
| } | ||
|
|
||
| impl From<PartitionStat> for PyPartitionStat { | ||
| fn from(inner: PartitionStat) -> Self { | ||
| Self { inner } | ||
| } | ||
| } | ||
|
|
||
| #[pymethods] | ||
| impl PyPartitionStat { | ||
| fn partition(&self) -> HashMap<String, String> { | ||
| self.inner.partition.clone() | ||
| } | ||
|
|
||
| fn record_count(&self) -> i64 { | ||
| self.inner.record_count | ||
| } | ||
|
|
||
| fn file_count(&self) -> u64 { | ||
| self.inner.file_count | ||
| } | ||
|
|
||
| fn total_size_bytes(&self) -> u64 { | ||
| self.inner.total_size_bytes | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use paimon::spec::Snapshot; | ||
| use pyo3::prelude::*; | ||
|
|
||
| #[pyclass(name = "Snapshot", module = "pypaimon_rust.datafusion")] | ||
| pub struct PySnapshot { | ||
| inner: Snapshot, | ||
| } | ||
|
|
||
| impl PySnapshot { | ||
| pub fn new(inner: Snapshot) -> Self { | ||
| Self { inner } | ||
| } | ||
| } | ||
|
|
||
| #[pymethods] | ||
| impl PySnapshot { | ||
| fn id(&self) -> i64 { | ||
| self.inner.id() | ||
| } | ||
|
|
||
| fn commit_time_ms(&self) -> u64 { | ||
| self.inner.time_millis() | ||
| } | ||
|
|
||
| fn total_record_count(&self) -> Option<i64> { | ||
| self.inner.total_record_count() | ||
| } | ||
|
|
||
| fn delta_record_count(&self) -> Option<i64> { | ||
| self.inner.delta_record_count() | ||
| } | ||
|
|
||
| fn commit_kind(&self) -> String { | ||
| self.inner.commit_kind().to_string() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use pyo3::prelude::*; | ||
|
|
||
| #[pyclass(name = "Tag", module = "pypaimon_rust.datafusion")] | ||
| pub struct PyTag { | ||
| name: String, | ||
| snapshot_id: i64, | ||
| } | ||
|
|
||
| impl PyTag { | ||
| pub fn new(name: String, snapshot_id: i64) -> Self { | ||
| Self { name, snapshot_id } | ||
| } | ||
| } | ||
|
|
||
| #[pymethods] | ||
| impl PyTag { | ||
| fn name(&self) -> String { | ||
| self.name.clone() | ||
| } | ||
|
|
||
| fn snapshot_id(&self) -> i64 { | ||
| self.snapshot_id | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is too weak for the main risk in this PR.
partition_stats()is only smoke-tested on a non-partitioned table, and the test accepts either 0 or 1 empty partition, so it would not catch regressions inmerge_active_entries, partition value formatting, or per-partition aggregation. Could we add a temporary-warehouse test with a real partitioned table and assert concretelist_partitions()/partition_stats()values, including record/file/size counts?