HDDS-15651. Roll back DiskBalancer move when markContainerForDelete fails#10593
Draft
arunsarin85 wants to merge 2 commits into
Draft
HDDS-15651. Roll back DiskBalancer move when markContainerForDelete fails#10593arunsarin85 wants to merge 2 commits into
arunsarin85 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When markContainerForDelete() fails after a container has been copied to the destination volume, treat the move as a failure instead of success.
Restore ContainerSet to the source replica, revert destination volume accounting, delete the destination replica directory, and do not queue the source replica for delayed deletion. Add a regression test.
Please describe your PR in detail:
Bug: DiskBalancer reported a successful move even when markContainerForDelete() failed on the source replica.
Fix: On mark failure, the move is rolled back and counted as a failure.
<style type="text/css"></style>
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15651
How was this patch tested?
Regression test
TestDiskBalancerTask.moveSucceedsDespiteMarkContainerForDeleteFailure (HDDS-15651):
Creates a CLOSED container on the source volume
Sets replicaDeletionDelay = 60_000 ms so delayed deletion does not hide duplicate-replica bugs
Look for on the source KeyValueContainer and makes markContainerForDelete() throw
Runs DiskBalancerTask.call()
repro_HDDS_markContainerForDelete_BEFORE_fix.log
repro_HDDS_markContainerForDelete_AFTER_fix.log