HDDS-15587. [Recon] Show 0 for offline DN pending deletion instead of -1#10585
Open
priyeshkaratha wants to merge 1 commit into
Open
HDDS-15587. [Recon] Show 0 for offline DN pending deletion instead of -1#10585priyeshkaratha wants to merge 1 commit into
priyeshkaratha wants to merge 1 commit into
Conversation
priyeshkaratha
changed the title
priyeshkaratha
changed the title
priyeshkaratha
force-pushed
the
HDDS-15587
branch
from
aa5c3b8 to
ee8fe09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the Capacity Distribution → Datanode Details section of Recon, if a datanode is selected and later goes offline, the node becomes disabled for new selection. However, if it was already selected, some metrics such as Pending Deletion are displayed as -1, which can be confusing to users.
To provide a better user experience, Recon should display 0 (or an appropriate default value) for these metrics when the selected datanode is offline or unavailable, instead of showing -1.
What is the link to the Apache JIRA
HDDS-15587
How was this patch tested?
Tested using unit test and manually.
