HDDS-15614. Remove Datanode download/pull container replication#10584
Open
errose28 wants to merge 9 commits into
Open
HDDS-15614. Remove Datanode download/pull container replication#10584errose28 wants to merge 9 commits into
errose28 wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Datanodes have used push replication to move containers by default since early 2023. There is no reason to continue using the pull model which is now disabled behind a feature flag. We can safely remove it, which will be easier to do before ZDU is merged into master.
Changes generated by Claude Code using various models with reviews and modifications by me.
Implementation Notes
AbstractReplicationTask#shouldOnlyRunOnInServiceDatanodescould block pull replication from running on these nodes.falsesince a decom/maintenance node will need to push its replicas to other datanodes before it can be removed. Therefore the switch was removed.ClosedContainerReplicatorwas removed, since it only worked for pull replication and there is no equivalent for push replication.Reviewer Notes
This change is fairly large and I could not find a good way to break it down, although I am open to suggestions. One alternative is to iteratively review the prod changes first, and once those look good move on to the test changes.
What is the link to the Apache JIRA
HDDS-15614
How was this patch tested?
TestOzoneContainerWithTLS#downloadContainercannot be cleanly switched to a pull model. See HDDS-15644 for details and a plan to add tests for TLS + container tokens on the replication path as a larger follow-up change after this PR.TestReplicationSupervisor#testReplicationImportReserveSpacewas removed, since the reserved space check is relevant on the target only, andReplicationSupervisoris now always the source.TestSendContainerRequestHandler#testNoSpaceOnTargetVolumewas added as a new test to cover this functionality.SendContainerRequestHandleris the receiving class on the target node in the push model.ReplicateContainerCommand#forTestwas no longer relevant. Tests now calltoTargetdirectly.Green run on my fork