HDDS-15446. Expose Hard Min Free Space Threshold via JMX#10575
Merged
Conversation
priyeshkaratha
approved these changes
Jun 22, 2026
priyeshkaratha
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anuragp010 for the patch and changes LGTM
Contributor
|
@devmadhuu Can you review the changes? |
sarvekshayr
reviewed
Jun 24, 2026
sarvekshayr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anuragp010 for the patch.
| private static final MetricsInfo HARD_MIN_FREE_SPACE = | ||
| Interns.info("HardMinFreeSpace", | ||
| "Minimum free space threshold (hard limit) enforced locally for writes, " + | ||
| "derived from hdds.datanode.volume.min.free.space.hard.limit.percent"); |
Contributor
There was a problem hiding this comment.
Should we include hdds.datanode.volume.min.free.space in the HardMinFreeSpace metric description to match MinFreeSpace?
The limit is determined by the higher of the hdds.datanode.volume.min.free.space and the hdds.datanode.volume.min.free.space.hard.limit.percent values.
Contributor
There was a problem hiding this comment.
Yes, better to mention that way
sarvekshayr
approved these changes
Jun 24, 2026
Contributor
|
Thanks @anuragp010 for the patch and @priyeshkaratha for the review. |
Contributor
Author
|
@priyeshkaratha , @sarvekshayr thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The hard minimum free space threshold is not available via JMX on Datanodes. The write path rejection logic uses the hard threshold, which is exposed through the getFreeSpaceToSpare method on HddsVolume. This PR exposes the metric in JMX.
What is the link to the Apache JIRA
HDDS-15446
How was this patch tested?