HDDS-15638. Conditional DeleteObjects#10572
Open
amaliujia wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@peterxcli trying to help on this effort. |
Member
|
Thanks, will take a look. You can also review the conditional delete patch |
Member
|
And actually I have a draft blog for conditional request. https://docs.google.com/document/d/1DwDKx5G90Vo_E9MES_OI_PegVwfbiI94_ysmT1iEszE/edit?usp=drivesdk Feel free to leave some comments or request to edit. |
peterxcli
reviewed
Jun 24, 2026
Comment on lines
+199
to
203
| static boolean matchesETag(String headerValue, String currentETag) { | ||
| return eTagMatches(headerValue, currentETag); | ||
| } | ||
|
|
||
| private static boolean eTagMatches(String headerValue, String currentETag) { |
Member
There was a problem hiding this comment.
let's just expose the existing func.
Suggested change
| static boolean matchesETag(String headerValue, String currentETag) { | |
| return eTagMatches(headerValue, currentETag); | |
| } | |
| private static boolean eTagMatches(String headerValue, String currentETag) { | |
| static boolean eTagMatches(String headerValue, String currentETag) { |
| return result; | ||
| } | ||
|
|
||
| private void deleteSingleObject(OzoneBucket bucket, DeleteObject deleteObject, |
Member
There was a problem hiding this comment.
this should be in server side, but I not sure how can we bring a map or a list of expected etags in proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change adds support for conditional DeleteObjects in the Ozone S3 Gateway, aligned with the AWS S3 DeleteObjects API for general purpose buckets.
Clients can include an optional element per object in the DeleteObjects XML body. The gateway deletes an object only when its current ETag matches the provided value. If the precondition fails, the per-object response includes a PreconditionFailed error instead of deleting the object.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15638
How was this patch tested?
Unit Test