Checksums: lack of information#1917
Open
cstamas wants to merge 1 commit into
Open
Conversation
This exception is quite special, as it covers many cases: real mismatch, processing issues during checksum calculation and lack of checksums. Deprecated all constructors and not using them in production code, instead provided helper methods for 3 cases, making sure that in each case we provide as much information as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
TrustedChecksumsArtifactResolverPostProcessoruses wrong ctor ofChecksumFailureExxeptionand thus, created exceptions with lack of information. This was easy mistake to do, as exception already had way too many constructors.Fix: This exception is quite special, as it covers many cases: real mismatch, processing issues during checksum calculation and lack of checksums. The Resolver intent is to always provide as much information as possible. Hence, deprecated all constructors, not using them in production code, instead using new provided helper methods for 3 cases (mismatch, lack of and processing error), making sure that in each case we provide as much information as possible.