fix(website): serve author avatar as local asset instead of GitHub hotlink#1377
Merged
Merged
Conversation
…tlink ASF infra does not allow hotlinking external images, so the GitHub avatar URL fails to load on the published site. Download the avatar into website/static/img/authors/ and reference it locally.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Mahout website/blog author metadata to stop hotlinking a GitHub avatar (disallowed by ASF infra) and instead reference a local static image asset path.
Changes:
- Switch
ryankertauthorimage_urlfrom a GitHub-hosted URL to a local/img/authors/ryankert.pngpath (consistent with the existingmahout-teamlocal image pattern).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASF infra does not allow hotlinking external images, so the GitHub avatar URL (
https://github.com/ryankert01.png) fails to load on the published site.website/static/img/authors/and commit it as a local static assetdocs/blog/authors.yml(the single source of truth synced towebsite/blogat build time) to reference/img/authors/ryankert.pngThis follows the same pattern as the existing
mahout-teamauthor entry, which already uses local/img/paths resolved throughuseBaseUrlin the custom Author component.Testing
website/static(Docusaurus servesstatic/at the site root)website/scripts/sync-docs.jsre-syncsdocs/blog→website/blogon every build (prebuildhook), so the source-of-truth edit propagates