fix(partitioning): convert nano timestamp partition values to nanoseconds#3653
Open
vishnuprakaz wants to merge 1 commit into
Open
fix(partitioning): convert nano timestamp partition values to nanoseconds#3653vishnuprakaz wants to merge 1 commit into
vishnuprakaz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3652
Rationale for this change
_to_partition_representationhas no handler forTimestampNanoType/TimestamptzNanoType, so adatetimepartition valuepasses through unchanged instead of being converted to nanoseconds since epoch. The manifest writer expects an int there, so
identity-partitioned writes on
timestamp_nscolumns would fail once v3 writing lands (#1551).This adds a handler for the two nano types, mirroring the existing microsecond one with
datetime_to_nanos.Happy to rework this or fold it into the v3 write effort if that's preferred.
Are these changes tested?
Yes, added unit tests covering
datetime, int passthrough andNonefor both nano types, plus the same cases for the microsecondtypes which weren't covered before.
Are there any user-facing changes?
No. Writing v3 tables is still gated, this just makes partitioned v3 writes work correctly once it's enabled.