Skip to content

fix: use removeprefix to decode DynamoDB namespace property keys #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −5
Open

fix: use removeprefix to decode DynamoDB namespace property keys #3602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
743e5fa
fix: use removeprefix to decode DynamoDB namespace property keys
anxkhn Jul 4, 2026
f3e94aa
fix: inline DynamoDB property prefix removal
anxkhn Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pyiceberg/catalog/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,10 @@ def _get_update_database_item(namespace_item: dict[str, Any], updated_properties


def _get_namespace_properties(namespace_dict: dict[str, str]) -> Properties:
return {_remove_property_prefix(key): val for key, val in namespace_dict.items() if key.startswith(PROPERTY_KEY_PREFIX)}
# removeprefix removes the literal prefix, unlike lstrip which removes any leading prefix characters
return {
key.removeprefix(PROPERTY_KEY_PREFIX): val for key, val in namespace_dict.items() if key.startswith(PROPERTY_KEY_PREFIX)
}


def _convert_dynamo_item_to_regular_dict(dynamo_json: dict[str, Any]) -> dict[str, str]:
Expand Down Expand Up @@ -888,7 +891,3 @@ def _convert_dynamo_item_to_regular_dict(dynamo_json: dict[str, Any]) -> dict[st

def _add_property_prefix(prop: str) -> str:
return PROPERTY_KEY_PREFIX + prop


def _remove_property_prefix(prop: str) -> str:
return prop.lstrip(PROPERTY_KEY_PREFIX)