[WIP] HBASE-29435 Add RestoreSnapshotHFileArchiver to guard against accidental data loss#8248
Draft
SwaraliJoshi wants to merge 1 commit into
Draft
Conversation
…tal data loss Introduce RestoreSnapshotHFileArchiver as a safe wrapper around HFileArchiver for use by RestoreSnapshotHelper. Before delegating any archive/delete operation, it validates that the target path does not fall under the production HBase root directory (hbase.rootdir). If it does, the operation is blocked with an IOException and an ERROR log to prevent accidental data loss. - Add RestoreSnapshotHFileArchiver with root-dir safety checks for archiveRegion and archiveFamilyByFamilyDir - Update RestoreSnapshotHelper to use RestoreSnapshotHFileArchiver instead of HFileArchiver directly (both call sites) - Add TestRestoreSnapshotHFileArchiver with 7 tests covering root-dir blocking, temp-dir allowing, sibling-path handling, and custom root dirs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce RestoreSnapshotHFileArchiver as a safe wrapper around HFileArchiver for use by RestoreSnapshotHelper. Before delegating any archive/delete operation, it validates that the target path does not fall under the production HBase root directory (hbase.rootdir). If it does, the operation is blocked with an IOException and an ERROR log to prevent accidental data loss.