Skip to content

Add bit and bool aggregate functions#806

Open
huangguasky wants to merge 1 commit into
apache:masterfrom
huangguasky:feature/issue-793-aggregate-functions
Open

Add bit and bool aggregate functions#806
huangguasky wants to merge 1 commit into
apache:masterfrom
huangguasky:feature/issue-793-aggregate-functions

Conversation

@huangguasky

Copy link
Copy Markdown

What changes were proposed in this pull request?

Add built-in aggregate functions for issue #793:

  • Implement BIT_AND for integer inputs.
  • Implement BIT_OR for integer inputs.
  • Implement BOOL_AND for boolean inputs.
  • Register the new aggregate functions in BuildInSqlFunctionTable.
  • Wire the new functions into runtime UDAF resolution.
  • Add unit tests and an SQL aggregate test resource covering multi-row aggregation.

How was this PR tested?

  • Tests have Added for the changes
  • Production environment verified

Validated with:

  • mvn -pl geaflow/geaflow-dsl/geaflow-dsl-plan -am '-Dtest=org.apache.geaflow.dsl.udf.agg.UDAFTest' '-Dsurefire.failIfNoSpecifiedTests=false' test
  • mvn -pl geaflow/geaflow-dsl/geaflow-dsl-runtime -am '-DskipTests' compile

Note: the targeted runtime SQL test command for AggregateTest#testAggregate_013 timed out locally before producing a surefire report.

Fixes #793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the aggregate functions BIT_AND / BIT_OR / BOOL_AND

1 participant