[FLINK-39985] Replace ReplaceMinusWithAntiJoinRule with Calcite Minus…#28522
Open
liuyongvs wants to merge 1 commit into
Open
[FLINK-39985] Replace ReplaceMinusWithAntiJoinRule with Calcite Minus…#28522liuyongvs wants to merge 1 commit into
liuyongvs wants to merge 1 commit into
Conversation
…ToAntiJoinRule Calcite 1.40 provides MinusToAntiJoinRule which is a superset of Flink ReplaceMinusWithAntiJoinRule: it supports n-way inputs (vs. 2-way only) and uses IS NOT DISTINCT FROM for NULL-safe comparison (semantically equivalent to Flink OR(=, AND(IS NULL, IS NULL))). This commit removes the Flink-specific rule and uses the Calcite rule instead.
liuyongvs
force-pushed
the
flink-39985-replace-minus-rule
branch
from
c74c667 to
1083208
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is follow up PR after Calcite upgrade to 1.40.0
There 1 Calcite classes which might be removed from Flink codebase
Brief change log
Replace ReplaceMinusWithAntiJoinRule with Calcite MinusToAntiJoinRule
Verifying this change
existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?