Skip to content

feat/support new client of prometheus#36

Open
qyi71 wants to merge 2 commits into
apache:mainfrom
qyi71:feat/suport_new_version_prometheus
Open

feat/support new client of prometheus#36
qyi71 wants to merge 2 commits into
apache:mainfrom
qyi71:feat/suport_new_version_prometheus

Conversation

@qyi71

@qyi71 qyi71 commented Jun 27, 2024

Copy link
Copy Markdown

#35

@qyi71

qyi71 commented Jun 27, 2024

Copy link
Copy Markdown
Author

apache/dubbo#14345

@qyi71

qyi71 commented Jun 27, 2024

Copy link
Copy Markdown
Author

@AlbumenJ 大佬 我理解这个pr 和apache/dubbo#14345 这个pr要有一个先合并成功才可以吧。要不然现在这两个pr互相依赖了

@AlbumenJ

AlbumenJ commented Jul 1, 2024

Copy link
Copy Markdown
Member

This is a breaking change?

@qyi71

qyi71 commented Jul 1, 2024

Copy link
Copy Markdown
Author

This is a breaking change?

新版prometheus 客户端包路径变了

@AlbumenJ

AlbumenJ commented Jul 2, 2024

Copy link
Copy Markdown
Member

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

@qyi71

qyi71 commented Jul 2, 2024

Copy link
Copy Markdown
Author

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

Users should replace dependencies instead of upgrade them ,I don't think it will affect the work of other metrics. of course, this requires your evaluation
new dependencies (prometheus-metrics-exporter-pushgateway、prometheus-metrics-core、micrometer-registry-prometheus)

@AlbumenJ

AlbumenJ commented Jul 3, 2024

Copy link
Copy Markdown
Member

Does it mean if we merge this update our users should also upgrade their prometheus client too? If there exist any other metrics systems in their project, how can it work?

Users should replace dependencies instead of upgrade them ,I don't think it will affect the work of other metrics. of course, this requires your evaluation new dependencies (prometheus-metrics-exporter-pushgateway、prometheus-metrics-core、micrometer-registry-prometheus)

e.g. Dubbo depends on the new version and Spring boot actuator depends on the old version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants