fix(gitlab): map WorkInProgress to IsDraft in MR converter#8982
Open
mfrancisc wants to merge 1 commit into
Open
fix(gitlab): map WorkInProgress to IsDraft in MR converter#8982mfrancisc wants to merge 1 commit into
mfrancisc wants to merge 1 commit into
Conversation
WorkInProgress was extracted from the GitLab API and stored in _tool_gitlab_merge_requests but never forwarded to code.PullRequest.IsDraft during conversion. Draft/WIP MRs were indistinguishable from non-draft MRs at the domain layer. - Add IsDraft: gitlabMr.WorkInProgress to the converter struct - Update e2e snapshot: MRs 145012495 and 158698019 now have is_draft=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkInProgresswas extracted from the GitLab API and stored in_tool_gitlab_merge_requestsbut never forwarded tocode.PullRequest.IsDraftduring conversion. Draft/WIP MRs were indistinguishable from non-draft MRs at the domain layer.Changes
IsDraft: gitlabMr.WorkInProgressto the MR converter structis_draft=1Note
GitLab deprecated
work_in_progressin favor ofdraft(API v4, GitLab 14.0+), but still returns it for backward compatibility. This fix uses the existing extracted field — adding support for the newerdraftfield is a separate concern.