test: Fix malformed regexp_instr error tests and add slt coverage#23620
Open
alamb wants to merge 1 commit into
Open
test: Fix malformed regexp_instr error tests and add slt coverage#23620alamb wants to merge 1 commit into
regexp_instr error tests and add slt coverage#23620alamb wants to merge 1 commit into
Conversation
The two existing 'statement error' tests for start < 1 placed the expected error message on the line after 'statement error', so the runner parsed the message as part of the SQL. The resulting two-line statement failed to parse and the bare 'statement error' accepted that parse error, meaning the start validation was never actually exercised (the expected text also said '1 based' while the actual error says '1-based'). Also add coverage for two previously untested paths: - the 'N must be 1 or greater' error for nth < 1 - a pattern column that alternates between two regexes in one batch, exercising the compiled-regex cache lookup for a previously seen pattern Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A (found while reviewing test coverage for #23540)
Rationale for this change
While checking
cargo llvm-covcoverage ofregexp_instr, I found that the twostatement errortests forstart < 1inregexp_instr.sltnever actually exercise the start validation.Coverage also showed two paths of
regexp_instruntested anywhere:N must be 1 or greatererror fornth < 1['abc', 'def', 'abc']). This path becomes more important with the memoization added in perf: optimizeregexp_instr(40% faster) #23540.What changes are included in this PR?
statement errortests so the expected error is matched inline against the real messagestatement errortest fornth < 1Are these changes tested?
Yes, this PR is only tests.
Are there any user-facing changes?
No