fix: align dictionary coercion across typed signatures#23549
Open
lyne7-sc wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#22905 introduced explicit dictionary encoding preservation for coercible function signatures, but dictionary inputs were still handled differently across
TypeSignatureClassvariants:Native(...)Integer,Numeric,Binary)AnyThis PR makes the encoding preservation contract consistent across all typed signature classes: coercion operates on the dictionary value type, and the dictionary encoding is restored only when
EncodingPreservation::dictionary()is enabled.An audit of the affected built-ins found two functions, Spark hex and bitmap_count, that intentionally handle dictionary inputs; both now opt in explicitly. Other affected functions generally expect materialized value arrays, so the new default also avoids cases where signature matching accepted a dictionary but the function implementation rejected it at execution time. Functions that continue to materialize dictionary inputs do not gain dictionary-aware execution efficiency yet, but they can opt in later if they add support for encoded inputs.
What changes are included in this PR?
bitmap_countand the binary variant of Sparkhex.Are these changes tested?
Anyinputs.to_hexmaterialization and verify thatbitmap_countpreserves its dictionary input without an additional cast toBinary.hexdictionary tests cover its opt-in preservation behavior.Are there any user-facing changes?
This is a behavioral API change for UDFs using typed non-Native classes such as
IntegerorBinary. UDFs relying on implicit dictionary preservation must now enableEncodingPreservation::dictionary()explicitly.TypeSignatureClass::Anyis unaffected. The upgrade guide has been updated, and this PR should carry theapi changelabel.