Skip to content

perf: optimize to_local_time in datafusion-functions #23545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andygrove wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: optimize to_local_time in datafusion-functions #23545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions datafusion/functions/src/datetime/to_local_time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
// specific language governing permissions and limitations
// under the License.

use std::ops::Add;
use std::sync::Arc;

use arrow::array::temporal_conversions::{MICROSECONDS, MILLISECONDS, NANOSECONDS};
use arrow::array::timezone::Tz;
use arrow::array::{ArrayRef, PrimitiveArray};
use arrow::datatypes::DataType::Timestamp;
Expand All @@ -26,7 +26,7 @@ use arrow::datatypes::{
ArrowTimestampType, DataType, TimestampMicrosecondType, TimestampMillisecondType,
TimestampNanosecondType, TimestampSecondType,
};
use chrono::{DateTime, MappedLocalTime, Offset, TimeDelta, TimeZone, Utc};
use chrono::{DateTime, MappedLocalTime, Offset, TimeZone, Utc};

use datafusion_common::cast::as_primitive_array;
use datafusion_common::{
Expand Down Expand Up @@ -337,24 +337,23 @@ pub fn adjust_to_local_time<T: ArrowTimestampType>(ts: i64, tz: Tz) -> Result<i6
.fix()
.local_minus_utc() as i64;

let adjusted_date_time = date_time.add(
// This should not fail under normal circumstances as the
// maximum possible offset is 26 hours (93,600 seconds)
TimeDelta::try_seconds(offset_seconds)
.ok_or_else(|| internal_datafusion_err!("Offset seconds should be less than i64::MAX / 1_000 or greater than -i64::MAX / 1_000"))?,
);

// convert the naive datetime back to i64
match T::UNIT {
Nanosecond => adjusted_date_time.timestamp_nanos_opt().ok_or_else(||
internal_datafusion_err!(
"Failed to convert DateTime to timestamp in nanosecond. This error may occur if the date is out of range. The supported date ranges are between 1677-09-21T00:12:43.145224192 and 2262-04-11T23:47:16.854775807"
)
),
Microsecond => Ok(adjusted_date_time.timestamp_micros()),
Millisecond => Ok(adjusted_date_time.timestamp_millis()),
Second => Ok(adjusted_date_time.timestamp()),
}
// Shifting an instant by a whole number of seconds is exact in every
// timestamp unit, so the offset is applied directly to the i64 value rather
// than round-tripping through chrono's calendar arithmetic. The scaling
// cannot overflow: the largest possible offset is 26 hours (93,600 seconds).
let offset = offset_seconds
* match T::UNIT {
Nanosecond => NANOSECONDS,
Microsecond => MICROSECONDS,
Millisecond => MILLISECONDS,
Second => 1,
};

ts.checked_add(offset).ok_or_else(|| {
internal_datafusion_err!(
"Failed to adjust timestamp to local time: the adjusted value is out of range"
)
})
}

#[cfg(test)]
Expand Down
Loading