ipmi: Uncensor port on sanitised logs

[GaOrtiga]

Description

When using IPMI, the password is censored before being shown in the logs, this censorship, however, filters for the -P parameter, ignoring case. This causes the port to be censored for no reason, as its parameter is -p. This PR uncensors the port while maintaining the censorship on the password, as well as fixes a typo in the method's name.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

The logs changed are used in two places, I checked both instances and verified that the port was no longer censored but the password still was.

How did you try to break this feature and the system with this change?

[sureshanaparti]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.00%. Comparing base (c361409) to head (8f91f45).

Files with missing lines	Patch %	Lines
...andmanagement/driver/ipmitool/IpmitoolWrapper.java	0.00%	3 Missing ⚠️
...er/ipmitool/IpmitoolOutOfBandManagementDriver.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12990      +/-   ##
============================================
- Coverage     18.00%   18.00%   -0.01%     
+ Complexity    16466    16465       -1     
============================================
  Files          5977     5977              
  Lines        537777   537777              
  Branches      66037    66037              
============================================
- Hits          96844    96843       -1     
  Misses       430011   430011              
- Partials      10922    10923       +1     

Flag	Coverage Δ
uitests	3.52% <ø> (ø)
unittests	19.17% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17435

[DaanHoogland]

clgtm

[winterhazel]

@GaOrtiga as this is a simple bug fix, could you target 4.20 instead?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17480