Fix logback dependency changes for 4.19.3#2088
Open
absurdfarce wants to merge 1 commit into
Open
Conversation
… of the original PR (apache#1901). The change that was actually merged attempted to bump us up to the most recent Java8-compatible logback impl. This moved us from 1.2.x to 1.3.x which in turn brought some dependency changes that were excessive, especially for a patch release.
tolbertam
approved these changes
May 11, 2026
Contributor
tolbertam
left a comment
tolbertam
left a comment
There was a problem hiding this comment.
👍 looks good, so for 4.19.2->.3 effectively we are just bumping loback-classic to 1.2.13? sgtm!
Contributor
Author
|
For sake of clarity this PR was made up of two commits:
These commits were subsequently squashed in a git rebase. Upshot: there was an explicit revert here. Just wanted to be clear on that point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #2051 and replace it with something closer to the intent of the original PR (#1901).
#2051 attempted to bump us up to the most recent Java8-compatible logback impl. This moved us from 1.2.x to 1.3.x which in turn brought some dependency changes that were excessive, especially for a patch release.