[AURON #1840] Preserve collect_set first-occurrence order#2285
Open
peter941221 wants to merge 1 commit into
Open
[AURON #1840] Preserve collect_set first-occurrence order#2285peter941221 wants to merge 1 commit into
peter941221 wants to merge 1 commit into
Conversation
peter941221
force-pushed
the
fix/auron-1840-collect-set-order
branch
from
46ef225 to
f092709
Compare
Author
|
Rebased this onto current master and kept the fix minimal. The change still just removes the size-based swap in AccSet::merge and adds order assertions for the merge cases. New CI is running on f092709. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AccSet::mergeno longer swaps accumulators by set size. That swap changed the encounter order ofcollect_set, so no-shuffle Spark checks could see values inrhs-firstorder instead of first-occurrence order.Why
Spark's
collect_setpreserves first-occurrence order in the no-shuffle path used by the affected aggregate suite.Testing
git diff --checkcargo +nightly test --manifest-path native-engine/datafusion-ext-plans/Cargo.toml test_acc_set_merge -- --nocapture(blocked here byrdkafka-sysWindows build failure:%1 is not a valid Win32 application. (os error 193))