Persist trigger context requirements#69843
Draft
idan192 wants to merge 5 commits into
Draft
Conversation
A stale task reference in a pinned serialized Dag can otherwise abort workload construction for every trigger in the supervisor batch and cause repeated triggerer restarts.
Release notes should make the restored triggerer behavior visible to operators evaluating a 3.3 patch release.
boring-cyborg
Bot
added
area:API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist whether a task trigger needs Dag context so ordinary deferrals can skip serialized-Dag lookup and deserialization.
trigger.start_from_triggercolumn without a server default or backfill, preserving rolling-upgradeNULLrows.This draft is stacked on #69842 and will be rebased onto
mainafter that backportable fix lands.Validation
Workload tests cover the no-lookup ordinary path, context-rich direct-to-triggerer workloads, both legacy classifications and their database persistence, missing-task removal without blocking a healthy workload, missing-Dag retry behavior, and unchanged asset workloads. Writer-path tests verify scheduler
Trueand ordinary-triggerFalsepersistence, including callbacks and assets. The SQLite 128-revision migration round trip and ORM/schema consistency checks pass locally; PostgreSQL and MySQL migration coverage is delegated to CI because Docker is unavailable in the local environment.closes: #69841
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines