Fix Neptune Analytics deferrable path: load custom waiter + forward hook params to triggers#69838
Closed
seanghaeli wants to merge 1 commit into
Closed
Fix Neptune Analytics deferrable path: load custom waiter + forward hook params to triggers#69838seanghaeli wants to merge 1 commit into
seanghaeli wants to merge 1 commit into
Conversation
…ook params to triggers The example_neptune_analytics system test fails deferrable-only. Two bugs: 1. Custom waiter never loaded: hook client_type is 'neptune-graph' so waiter_path derives 'neptune-graph.json', but the file shipped as 'neptune_analytics.json'. get_waiter fell through to botocore's official ImportTaskCancelled waiter, which fails on any non-CANCELLING/CANCELLED status -- so a fast import reaching SUCCEEDED before cancel raised NeptuneImportTaskCancellationFailedError. Renamed the file to match. 2. region_name/verify/botocore_config were not forwarded to the deferred triggers, so the triggerer rebuilt the async hook with region_name=None (sync path passes because it uses self.hook). Forwarded them to all 8 defer() sites. Adds regression tests: a waiter-loads test and TestNeptuneDeferForwardsHookParams.
boring-cyborg
Bot
added
area:providers
provider:amazon
Contributor
Author
|
Closing — investigation against the real pipeline traceback showed this doesn't fix the actual deferrable failure. The failing call is a sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward additional hook params to the deferred triggers to fix
example_neptune_analyticson the deferrable path (currently failing)